From 7e0dbe8c484f39ca85f59e4f85067a0fba994d96 Mon Sep 17 00:00:00 2001 From: Vahid Sohrabloo Date: Mon, 20 Feb 2017 09:04:20 +0330 Subject: [PATCH] Add more test in FileSize --- client_test.go | 14 ++++++++++++++ ftp.go | 7 +------ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/client_test.go b/client_test.go index 161dc11..1f9cf81 100644 --- a/client_test.go +++ b/client_test.go @@ -104,6 +104,20 @@ func testConn(t *testing.T, disableEPSV bool) { t.Errorf("file size %q, expected %q", fileSize, 14) } + data = bytes.NewBufferString("") + err = c.Stor("tset", data) + if err != nil { + t.Error(err) + } + + fileSize, err = c.FileSize("tset") + if err != nil { + t.Error(err) + } + if fileSize != 0 { + t.Errorf("file size %q, expected %q", fileSize, 0) + } + fileSize, err = c.FileSize("not-found") if err == nil { t.Fatal("expected error, got nil") diff --git a/ftp.go b/ftp.go index 03dd7c7..b2b491e 100644 --- a/ftp.go +++ b/ftp.go @@ -414,12 +414,7 @@ func (c *ServerConn) FileSize(path string) (int64, error) { return 0, err } - size, err := strconv.ParseInt(msg, 10, 64) - if err != nil { - return 0, err - } - - return size, nil + return strconv.ParseInt(msg, 10, 64) } // Retr issues a RETR FTP command to fetch the specified file from the remote