Use error values in tests

This commit is contained in:
Julien Laffaye
2019-01-22 16:04:06 +01:00
parent 72f5c01749
commit b218223d02
2 changed files with 15 additions and 13 deletions

View File

@@ -9,6 +9,8 @@ import (
)
var errUnsupportedListLine = errors.New("unsupported LIST line")
var errUnsupportedListDate = errors.New("unsupported LIST date")
var errUnknownListEntryType = errors.New("unknown entry type")
type parseFunc func(string, time.Time, *time.Location) (*Entry, error)
@@ -132,7 +134,7 @@ func parseLsListLine(line string, now time.Time, loc *time.Location) (*Entry, er
case 'l':
e.Type = EntryTypeLink
default:
return nil, errors.New("unknown entry type")
return nil, errUnknownListEntryType
}
if err := e.setTime(fields[5:8], now, loc); err != nil {
@@ -246,7 +248,7 @@ func (e *Entry) setTime(fields []string, now time.Time, loc *time.Location) (err
} else { // only the date
if len(fields[2]) != 4 {
return errors.New("invalid year format in time string")
return errUnsupportedListDate
}
timeStr := fmt.Sprintf("%s %s %s 00:00", fields[1], fields[0], fields[2])
e.Time, err = time.ParseInLocation("_2 Jan 2006 15:04", timeStr, loc)