brouzouf/ftp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid strings.Split

Browse Source 
This results in less function calls.
This commit is contained in:
Julian Kornberger 2015-08-29 13:20:47 +02:00
parent 1b24570309
commit b9430bdb4a
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ftp.go
View File

@ -290,14 +290,18 @@ var errUnsupportedListLine = errors.New("Unsupported LIST line")
// parseRFC3659ListLine parses the style of directory line defined in RFC 3659.
func parseRFC3659ListLine(line string) (*Entry, error) {
if i := strings.Index(line, ";"); i < 0 || i > strings.Index(line, " ") {
iSemicolon := strings.Index(line, ";")
iWhitespace := strings.Index(line, " ")
if iSemicolon < 0 || iSemicolon > iWhitespace {
return nil, errUnsupportedListLine
}
e := &Entry{}
arr := strings.Split(line, "; ")
e.Name = arr[1]
for _, field := range strings.Split(arr[0], ";") {
e := &Entry{
Name: line[iWhitespace+1 : len(line)],
}
for _, field := range strings.Split(line[:iWhitespace-1], ";") {
i := strings.Index(field, "=")
if i < 1 {
return nil, errUnsupportedListLine