brouzouf/ftp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
341 Commits 8 Branches 6 Tags
Commit Graph

341 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Julien Laffaye
6696131620
Create dependabot.yml 2022-06-10 12:36:43 -04:00
Julien Laffaye
dfa1e758f3
Merge pull request #257 from tauu/cmd-type 
support for the TYPE command
 2022-05-23 20:19:17 -04:00
Georg Wechslberger
b29e1f6c62 refactor: rename TransferTypeImage to TransferTypeBinary 2022-05-23 17:21:05 +02:00
Georg Wechslberger
190f39e8b2 feat: support TYPE command 2022-05-23 12:36:17 +02:00
Julien Laffaye
d2c44e311e Restore previous behavior for List 
Fixes #251
 2022-03-10 15:20:11 -05:00
Julien Laffaye
813c8a8384 Add test for DialWithDialer 2022-03-08 20:25:35 -05:00
Julien Laffaye
a8377c07ac Add test for DialWithDialFunc 2022-03-08 19:06:48 -05:00
Julien Laffaye
48e53fcac1 Add tests for EntryType 2022-03-08 18:57:09 -05:00
Julien Laffaye
30e028f001 Check errors in tests/mocks 2022-03-08 18:35:30 -05:00
Julien Laffaye
a81b090061 Use multierror in more places 
While I'm here, do not allocate multierror.Error, multierror.Append will
do it when needed.
 2022-03-01 13:14:25 -05:00
Julien Laffaye
212daf295f Use tls.DialWithDialer which does the handshake 
tls.DialWithDialer also better handle special error cases
 2022-02-28 20:43:42 -05:00
Julien Laffaye
fed5bc26b7 Return all errors from Stor functions 
To not hide some errors
 2022-02-28 20:13:24 -05:00
Julien Laffaye
02685330ee
Merge pull request #246 from morrowc/master 
Documentation update.
 2022-02-01 17:25:55 -05:00
Chris Morrow
ee119b0742
Keep the comment markers consistent. 2022-01-10 02:14:34 +00:00
Chris Morrow
f82be3d90b
Documentation update. 
I believe you say: "Step" but mean "Next" since there is no Step()
function.
 2022-01-10 01:57:22 +00:00
Julien Laffaye
1182040339
Merge pull request #233 from rclone/pr-modtime 
Add SetTime command, related options and state getters
 2021-11-17 16:36:18 -05:00
Julien Laffaye
0112733660
Merge pull request #237 from rclone/pr-timeout 
Nudge control connection deadline before reading the data closing status (Try 2)
 2021-11-17 16:32:13 -05:00
Ivan Andreev
90b220bedb Add time commands, related options, state getters and unit tests 2021-10-30 00:10:15 +03:00
Julien Laffaye
b1140299f4 Add cache to unit tests workflow 2021-10-28 23:27:51 -04:00
Julien Laffaye
88af36c520 Switch to golangci-lint, its faster 2021-10-28 23:16:01 -04:00
Julien Laffaye
7a2bce30c7 Use github actions instead of travis-ci 2021-10-28 22:39:57 -04:00
Julien Laffaye
6a13e1e753
Merge pull request #234 from rclone/pr-debuglist 
Debug directory listings
 2021-10-28 20:31:32 -04:00
Ivan Andreev
ae8a71d543 Debug directory listings 2021-10-03 18:40:19 +03:00
Ivan Andreev
53b6bfa4cd Nudge control connection deadline before reading the data closing status 2021-09-11 16:36:35 +03:00
Julien Laffaye
5d41901190 Fix issues reported by goimports 2021-03-06 19:44:19 -05:00
Julien Laffaye
64cacdb711 Fix issues reported by shadow 2021-03-06 19:43:28 -05:00
Julien Laffaye
05cd33e2ad Fix issues reported by errcheck 2021-03-06 19:36:26 -05:00
Julien Laffaye
52feea7744 Fix spelling error reported by goreportcard.com 2021-03-05 10:58:28 -05:00
Julien Laffaye
23a84a6d0e Replace godoc badge with pkg.go.dev 2021-03-05 10:52:22 -05:00
Julien Laffaye
c3c8c7ac65
Merge pull request #219 from ivandeex/master 
trim trailing whitespace from the list commands
 2021-03-02 14:57:56 -05:00
Julien Laffaye
cc3a8b417c
Merge pull request #221 from ncw/fix-tls-zero-length 
Fix STOR of zero length files to ProFTPd with TLS
 2021-03-02 14:53:12 -05:00
Nick Craig-Wood
a4e9650823 Fix STOR of zero length files to ProFTPd with TLS 
Before this change, uploading a zero length file via TLS meant that
the tls.Handshake function was never called.

ProFTPd quite properly refuses to accept an empty TCP connection with
no TLS handshake as a zero length upload and gives the error

    425 Unable to build data connection: Operation not

See: https://forum.rclone.org/t/rclone-ftps-explicit-rclone-touch-empty-files-proftpd-unable-to-build-data-connection-operation-not-permitted/22522
 2021-03-01 16:01:20 +00:00
Ivan Andreev
24897db640 Trim trailing whitespace from list commands 
Listing a current directory (when the path argument is empty)
would send the command "LIST " with trailing whitespace to FTP
resulting in 500 errors with Solaris FTP server.
This patch fixes that.
 2021-02-14 19:48:19 +03:00
Julien Laffaye
9aae4d1511
Merge pull request #196 from ncw/fix-disable-mlsd 
Add a DialWithDisabledMLSD option to ignore MLSD if advertised
 2020-11-12 14:50:30 -05:00
Nick Craig-Wood
624bcac8b4 Add a DialWithDisabledMLSD option to ignore MLSD if advertised 
This is useful for servers which advertise MLSD (eg some versions of
Serv-U) but don't support it properly.
 2020-11-05 11:42:34 +00:00
Julien Laffaye
0de5c29d45 Fix issues reported by staticcheck 2020-10-21 22:10:46 +02:00
Julien Laffaye
333201f85f
Merge pull request #213 from mafredri/fix-tests 
Fix tests
 2020-10-21 15:28:09 -04:00
Julien Laffaye
9aec86d811
Merge pull request #212 from mafredri/remove-naked-returns 
Remove naked returns
 2020-10-21 15:27:15 -04:00
Mathias Fredriksson
420cf7bbfd
Fix tests 2020-10-20 21:16:41 +03:00
Mathias Fredriksson
744ff9c18a
Remove naked returns 2020-10-20 20:51:56 +03:00
Julien Laffaye
a50ad6ffd6
Merge pull request #202 from ncw/fix-197-FEAT 
Implement PRET command for distributed ftp servers, eg drftpd
 2020-10-19 13:47:21 -04:00
Nick Craig-Wood
fcad893ae7 Implement PRET command for distributed ftp servers, eg drftpd 
See: https://tools.ietf.org/html/draft-dd-pret-00

Fixes #197
 2020-10-19 17:59:40 +01:00
Julien Laffaye
43afc84ae3
Merge pull request #199 from ncw/fix-198 
Fix Stor() no longer reporting errors from the io.Reader passed in
 2020-10-19 10:04:29 -04:00
Julien Laffaye
1344bef09e
Merge pull request #201 from ncw/fix-200-FEAT 
Delay FEAT command until after Login - fixes #200
 2020-10-19 10:01:38 -04:00
Nick Craig-Wood
9f5200151c Delay FEAT command until after Login - fixes #200 
Some servers require the user to be logged in to run FEAT

    ftp://serverftp:2121: Connecting to FTP server
    FTP Rx: "220 DrFTPD+ 2.0 (+STABLE+) $Revision: 1949 $ http://drftpd.org"
    FTP Tx: "AUTH TLS"
    FTP Rx: "234 AUTH TLS successful"
    FTP Tx: "FEAT"
    FTP Rx: "530 Not logged in."
 2020-09-12 11:30:42 +01:00
Nick Craig-Wood
c0343a706b Fix Stor() no longer reporting errors from the io.Reader passed in 
This commit

4a68979b896a741e always return the ReadResponse error after an upload

Broke the error return from Stor().  If you attempt to upload a file
with Stor() and the io.Reader that you passed in returns an error,
this was not returned by the Stor() command leading the user to think
the file was uploaded correctly.

This was detected by rclone's unit tests and the exact commit was
pinpointed with git commit.

This commit fixes it by returning the error from io.Copy or the error
from ReadResponse - the latter if they are both set.

Fixes #198
 2020-09-11 17:14:05 +01:00
Julien Laffaye
39e3779af0
Merge pull request #192 from drakkan/resp_error 
try to read the server response after a failed upload
 2020-08-12 10:35:50 -04:00
Nicola Murino
4a68979b89 always return the ReadResponse error after an upload 2020-08-06 16:44:05 +02:00
Julien Laffaye
c2ee4fa250
Merge pull request #178 from crazy-max/optional-utf8 
Make "OPTS UTF8 ON" optional
 2020-07-30 09:57:23 -04:00
Nicola Murino
08a1e2e380 try to read the server response after a failed upload 
if the upload failed we still need to try to read the server
response otherwise if the failure is not due to a connection problem,
for example the server denied the upload for quota limits, we miss
the response and we cannot use the connection to send other commands

Here is what happen before this patch:

C->S STOR test_file1.dat
S->C 150 Using transfer connection
S->C 550 Could not transfer file: denying write due to space limit

the client does not read the above 550 response and send the next command, so
the response for the STOR response will be readed as response for the next
command
 2020-07-30 14:55:31 +02:00