fix out of bounds miscomputation

Reviewed-on: #2

addr.go

@@ -84,7 +84,7 @@ func (a Addr) ValidSnapshots() ([]*ZfsSnapshot, error) {
 	}
 }
 
-func (a Addr) SetManaged(val bool) error {
+func (a Addr) SetManaged(managed bool) error {
 	log.WithFields(log.Fields{"addr": a}).Debugf("starting")
 	defer log.WithFields(log.Fields{"addr": a}).Debugf("done")
 
@@ -99,9 +99,9 @@ func (a Addr) SetManaged(val bool) error {
 	} else {
 		fs.mx.Lock()
 		defer fs.mx.Unlock()
-		if fs.managed != val {
+		if fs.managed != managed {
 			var cmd string
-			if val {
+			if managed {
 				cmd = fmt.Sprintf("zfs set %s=+ %s", zfsManagedPropertyName, a.Path())
 			} else {
 				cmd = fmt.Sprintf("zfs set %s=- %s", zfsManagedPropertyName, a.Path())
@@ -111,7 +111,7 @@ func (a Addr) SetManaged(val bool) error {
 				return err
 			}
 		}
-		fs.managed = val
+		fs.managed = managed
 		return nil
 	}
 }

app.go

@@ -478,7 +478,7 @@ func (a *App) Transfer() error {
 	defer log.WithFields(log.Fields{"app": a.name}).Debugf("done")
 
 	for _, src := range a.sources {
-		backedUp := false
+		dests := make([]Addr, 0)
 		for _, dest := range a.destinations {
 			dest2 := dest.Append("/" + src.Box() + "/" + src.Path())
 			if dest2.Online() {
@@ -486,18 +486,17 @@ func (a *App) Transfer() error {
 					log.WithFields(log.Fields{"app": a.name, "call": "Mkdir", "attr": dest, "error": err}).Errorf("")
 					return err
 				}
-				if err := TransferZfs(src, dest2); err != nil {
-					log.WithFields(log.Fields{"app": a.name, "call": "TransferZfs", "src": src, "dest": dest, "error": err}).Errorf("")
-					return err
-				}
 				if err := dest2.SetManaged(true); err != nil {
 					log.WithFields(log.Fields{"app": a.name, "call": "SetManaged", "src": src, "dest": dest, "error": err}).Errorf("")
 					return err
 				}
-				backedUp = true
+				dests = append(dests, dest2)
 			}
 		}
-		if backedUp {
+		if n, err := TransferZfs(src, dests); err != nil {
+			log.WithFields(log.Fields{"app": a.name, "call": "TransferZfs", "src": src, "dests": dests, "error": err}).Errorf("")
+			return err
+		} else if n > 0 {
 			if err := src.SetBackedUp(true); err != nil {
 				log.WithFields(log.Fields{"app": a.name, "call": "SetBackedUp", "src": src, "error": err}).Errorf("")
 				return err

box.go

@@ -139,22 +139,39 @@ func (b *Box) Exec(cmd string) (r string, err error) {
 	return s.Exec(cmd)
 }
 
-func TransferZfs(from, to Addr) error {
+func TransferZfs(from Addr, to []Addr) (int, error) {
+	log.WithFields(log.Fields{"from": from, "to": to}).Debugf("starting")
+	defer log.WithFields(log.Fields{"from": from, "to": to}).Debugf("done")
+
+	count := 0
+
+	dests := make([]Addr, 0)
+	for _, dest := range to {
+		if cfg.box[from.Box()].allowDirectConnect && cfg.box[dest.Box()].allowDirectConnect {
+			if err := TransferDirectZfs(from, dest); err != nil {
+				log.WithFields(log.Fields{"from": from, "to": to, "call": "TransferDirectZfs", "attr": dest, "error": err}).Errorf("")
+				return count, err
+			} else {
+				count++
+			}
+		} else {
+			dests = append(dests, dest)
+		}
+	}
+
+	return count, nil
+
+}
+
+func TransferDirectZfs(from, to Addr) error {
 	log.WithFields(log.Fields{"from": from, "to": to}).Debugf("starting")
 	defer log.WithFields(log.Fields{"from": from, "to": to}).Debugf("done")
 
 	var (
 		err                        error
 		fromSnapshots, toSnapshots []*ZfsSnapshot
-		directTransfer             bool
 	)
 
-	if cfg.box[from.Box()].allowDirectConnect && cfg.box[to.Box()].allowDirectConnect {
-		directTransfer = true
-	} else {
-		directTransfer = false
-	}
-
 	if fromSnapshots, err = from.ValidSnapshots(); err != nil {
 		log.WithFields(log.Fields{"from": from, "to": to, "call": "ValidSnapshots", "attr": from, "error": err}).Errorf("")
 		return err
@@ -171,7 +188,6 @@ func TransferZfs(from, to Addr) error {
 
 	if len(toSnapshots) == 0 {
 		log.WithFields(log.Fields{"from": from, "to": to}).Debugf("initiating destination")
-		if directTransfer {
 		if _, err := to.BoxExec("ssh " + from.Box() + " zfs send " + fromSnapshots[0].String() + " | zfs recv -F " + to.Path()); err != nil {
 			log.WithFields(log.Fields{"from": from, "to": to, "call": "BoxExec", "error": err}).Errorf("")
 			return err
@@ -179,21 +195,23 @@ func TransferZfs(from, to Addr) error {
 		newToSnapshot := &ZfsSnapshot{name: fromSnapshots[0].name, fs: cfg.box[to.Box()].zfs.filesystems[to.Path()]}
 		toSnapshots = append(toSnapshots, newToSnapshot)
 		cfg.box[to.Box()].zfs.filesystems[to.Path()].AddSnapshot(newToSnapshot)
-		} else {
-			//handle indirect transfer
-		}
 
 	}
 
-	fromFromSnapshotId := -1
+	fromFromSnapshotId := len(fromSnapshots) - 1
-	lastToSnapshot := toSnapshots[len(toSnapshots)-1]
+	fromToSnapshotId := -1
-	log.WithFields(log.Fields{"from": from, "to": to}).Debugf("searching last snapshot %s", lastToSnapshot.String())
+	for fromFromSnapshotId >= 0 {
-	for id, v := range fromSnapshots {
+		fromToSnapshotId = len(toSnapshots) - 1
-		if v.name == lastToSnapshot.name {
+		for fromToSnapshotId >= 0 {
-			fromFromSnapshotId = id
+			if fromSnapshots[fromFromSnapshotId].name == toSnapshots[fromToSnapshotId].name {
-			log.WithFields(log.Fields{"from": from, "to": to}).Debugf("found %s", v.String())
 				break
 			}
+			fromToSnapshotId = fromToSnapshotId - 1
+		}
+		if fromToSnapshotId >= 0 {
+			break
+		}
+		fromFromSnapshotId = fromFromSnapshotId - 1
 	}
 
 	if fromFromSnapshotId == -1 {
@@ -204,14 +222,10 @@ func TransferZfs(from, to Addr) error {
 
 	if fromFromSnapshotId < len(fromSnapshots)-1 {
 		log.WithFields(log.Fields{"from": from, "to": to}).Debugf("transfering from %s to %s", fromSnapshots[fromFromSnapshotId].name, fromSnapshots[len(fromSnapshots)-1].name)
-		if directTransfer {
 		if _, err := to.BoxExec("ssh " + from.Box() + " zfs send -I " + fromSnapshots[fromFromSnapshotId].String() + " " + fromSnapshots[len(fromSnapshots)-1].String() + " | zfs recv -F " + to.Path()); err != nil {
 			log.WithFields(log.Fields{"from": from, "to": to, "call": "BoxExec", "error": err}).Errorf("")
 			return err
 		}
-		} else {
-			// handle indirect transfer
-		}
 
 		for _, v := range fromSnapshots[fromFromSnapshotId+1:] {
 			cfg.box[to.Box()].zfs.filesystems[to.Path()].AddSnapshot(&ZfsSnapshot{name: v.name, fs: cfg.box[to.Box()].zfs.filesystems[to.Path()]})

version.go

@@ -1,7 +1,7 @@
 // Code generated by version.sh (@generated) DO NOT EDIT.
 package main
-var githash = "1a1713e"
+var githash = "2ca0695"
-var branch = "v2"
+var branch = "master"
-var buildstamp = "2023-08-21_12:35:47"
+var buildstamp = "2023-09-10_16:42:46"
-var commits = "83"
+var commits = "87"
-var version = "1a1713e-b83 - 2023-08-21_12:35:47"
+var version = "2ca0695-b87 - 2023-09-10_16:42:46"

zfs.go

@@ -311,6 +311,9 @@ func (fs *ZfsFs) AddSnapshot(s *ZfsSnapshot) error {
 }
 
 func (fs *ZfsFs) ValidSnapshots() []*ZfsSnapshot {
+	log.WithFields(log.Fields{"box": fs.zfs.box.name, "fs": fs.path}).Debugf("starting")
+	defer log.WithFields(log.Fields{"box": fs.zfs.box.name, "fs": fs.path}).Debugf("done")
+
 	tab := make([]*ZfsSnapshot, 0)
 
 	for _, s := range fs.snapshots {