100 Commits
Author SHA1 Message Date
Julien Laffaye 260999f2de Secure GitHub workflows 2022-09-07 18:14:30 -04:00
Julien Laffaye f1ba13192b Add dependabot for github-actions 2022-09-07 18:03:34 -04:00
Julien Laffaye 9c3c2fd740 Add CodeQL and golangci-lint badges 2022-09-07 18:02:26 -04:00
Julien LaffayeandGitHub be12fe0263 Create codeql-analysis.yml 2022-09-07 17:48:18 -04:00
Julien Laffaye b85cf1edcc Add default timeout to instantiate connection 2022-08-28 21:58:25 -04:00
Julien Laffaye 4d1d644cf1 Mark Connect() and DialWithTimeout() as deprecated 2022-08-18 12:44:22 -04:00
Julien Laffaye 5a2fd50da8 ioutil is deprecated, use io package instead 2022-08-18 11:18:54 -04:00
Julien Laffaye 9cda78131d Fix transferring spelling. 2022-08-18 10:17:32 -04:00
Julien Laffaye 39592b91e4 Assign type to TransferType constants 2022-08-17 19:43:45 -04:00
Julien Laffaye fa83b53d0e Use tls.Dialer to be able to use DialContext 2022-08-17 19:35:55 -04:00
Julien Laffaye 45482d097e Use assert package to simplify tests 2022-08-17 19:24:40 -04:00
Julien Laffaye 560423fa8a DialWithNetConn is a special case of DialWithDialFunc 2022-08-17 18:41:24 -04:00
Julien LaffayeandGitHub 11536801d1 Merge pull request #264 from jlaffaye/dependabot/go_modules/github.com/stretchr/testify-1.8.0
Bump github.com/stretchr/testify from 1.7.2 to 1.8.0
2022-06-30 12:50:35 -04:00
Julien LaffayeandGitHub 60a941566c Merge pull request #259 from jlaffaye/dependabot/go_modules/github.com/stretchr/testify-1.7.2
Bump github.com/stretchr/testify from 1.6.1 to 1.7.2
2022-06-12 11:18:34 -04:00
Julien LaffayeandGitHub 6696131620 Create dependabot.yml 2022-06-10 12:36:43 -04:00
Julien LaffayeandGitHub dfa1e758f3 Merge pull request #257 from tauu/cmd-type
support for the TYPE command
2022-05-23 20:19:17 -04:00
Julien Laffaye d2c44e311e Restore previous behavior for List
Fixes #251
2022-03-10 15:20:11 -05:00
Julien Laffaye 813c8a8384 Add test for DialWithDialer 2022-03-08 20:25:35 -05:00
Julien Laffaye a8377c07ac Add test for DialWithDialFunc 2022-03-08 19:06:48 -05:00
Julien Laffaye 48e53fcac1 Add tests for EntryType 2022-03-08 18:57:09 -05:00
Julien Laffaye 30e028f001 Check errors in tests/mocks 2022-03-08 18:35:30 -05:00
Julien Laffaye a81b090061 Use multierror in more places
While I'm here, do not allocate multierror.Error, multierror.Append will
do it when needed.
2022-03-01 13:14:25 -05:00
Julien Laffaye 212daf295f Use tls.DialWithDialer which does the handshake
tls.DialWithDialer also better handle special error cases
2022-02-28 20:43:42 -05:00
Julien Laffaye fed5bc26b7 Return all errors from Stor functions
To not hide some errors
2022-02-28 20:13:24 -05:00
Julien LaffayeandGitHub 02685330ee Merge pull request #246 from morrowc/master
Documentation update.
2022-02-01 17:25:55 -05:00
Julien LaffayeandGitHub 1182040339 Merge pull request #233 from rclone/pr-modtime
Add SetTime command, related options and state getters
2021-11-17 16:36:18 -05:00
Julien LaffayeandGitHub 0112733660 Merge pull request #237 from rclone/pr-timeout
Nudge control connection deadline before reading the data closing status (Try 2)
2021-11-17 16:32:13 -05:00
Julien Laffaye b1140299f4 Add cache to unit tests workflow 2021-10-28 23:27:51 -04:00
Julien Laffaye 88af36c520 Switch to golangci-lint, its faster 2021-10-28 23:16:01 -04:00
Julien Laffaye 7a2bce30c7 Use github actions instead of travis-ci 2021-10-28 22:39:57 -04:00
Julien LaffayeandGitHub 6a13e1e753 Merge pull request #234 from rclone/pr-debuglist
Debug directory listings
2021-10-28 20:31:32 -04:00
Julien LaffayeandGitHub c3c8c7ac65 Merge pull request #219 from ivandeex/master
trim trailing whitespace from the list commands
2021-03-02 14:57:56 -05:00
Julien LaffayeandGitHub cc3a8b417c Merge pull request #221 from ncw/fix-tls-zero-length
Fix STOR of zero length files to ProFTPd with TLS
2021-03-02 14:53:12 -05:00
Julien LaffayeandGitHub 9aae4d1511 Merge pull request #196 from ncw/fix-disable-mlsd
Add a DialWithDisabledMLSD option to ignore MLSD if advertised
2020-11-12 14:50:30 -05:00
Julien Laffaye 0de5c29d45 Fix issues reported by staticcheck 2020-10-21 22:10:46 +02:00
Julien LaffayeandGitHub 333201f85f Merge pull request #213 from mafredri/fix-tests
Fix tests
2020-10-21 15:28:09 -04:00
Julien LaffayeandGitHub 9aec86d811 Merge pull request #212 from mafredri/remove-naked-returns
Remove naked returns
2020-10-21 15:27:15 -04:00
Julien LaffayeandGitHub a50ad6ffd6 Merge pull request #202 from ncw/fix-197-FEAT
Implement PRET command for distributed ftp servers, eg drftpd
2020-10-19 13:47:21 -04:00
Julien LaffayeandGitHub 43afc84ae3 Merge pull request #199 from ncw/fix-198
Fix Stor() no longer reporting errors from the io.Reader passed in
2020-10-19 10:04:29 -04:00
Julien LaffayeandGitHub 1344bef09e Merge pull request #201 from ncw/fix-200-FEAT
Delay FEAT command until after Login - fixes #200
2020-10-19 10:01:38 -04:00
Julien LaffayeandGitHub 39e3779af0 Merge pull request #192 from drakkan/resp_error
try to read the server response after a failed upload
2020-08-12 10:35:50 -04:00
Julien LaffayeandGitHub c2ee4fa250 Merge pull request #178 from crazy-max/optional-utf8
Make "OPTS UTF8 ON" optional
2020-07-30 09:57:23 -04:00
Julien LaffayeandGitHub a3536fc55e Merge pull request #183 from jawr/walker_path_fix
Rework walker.Next
2020-07-28 14:05:16 -04:00
Julien LaffayeandGitHub e31b4effea Merge pull request #188 from Techassi/typeentry-string
EntryType String() function
2020-07-28 13:54:05 -04:00
Julien LaffayeandGitHub 13949d3891 Merge pull request #190 from ncw/fix-pureftpd
Workaround pure-ftpd connections failing with "Unknown command"
2020-07-20 15:47:10 -04:00
Julien LaffayeandGitHub 5d10dd64f6 Merge pull request #187 from novalagung/master
add documentation shortcut
2020-07-15 12:42:56 -04:00
Julien LaffayeandGitHub 55bbb372b8 Merge pull request #185 from digineo/code-improvements
Code improvements
2020-07-08 13:50:26 -04:00
Julien LaffayeandGitHub 5563613968 Merge pull request #176 from vcraescu/fix_walk
fix_walk
2020-06-02 14:09:15 -04:00
Julien Laffaye b9f3ade291 Merge branch 'master' of github.com:jlaffaye/ftp 2020-04-23 00:49:57 +02:00
Julien Laffaye ac1574d383 Add DialWithExplicitTLS 2020-04-23 00:49:43 +02:00
Julien LaffayeandGitHub 59f85871cf Merge pull request #169 from flowrean/append-cmd
Add support for FTP append (APPE) command
2020-04-22 18:29:36 -04:00
Julien Laffaye d4caf6ffca Add close on read example
Fixes #171
2020-03-31 16:49:19 +02:00
Julien LaffayeandGitHub 041eae9a3d Merge pull request #141 from johnepiscopo/add-walk
Adds the ability to walk through a directory tree
2020-03-13 11:03:37 -04:00
Julien Laffaye 6841a2daa0 stale bot: ignore accepted issues 2020-03-09 18:13:36 +01:00
Julien Laffaye e1b8fdd0dc Add stale bot 2019-12-17 23:19:57 -05:00
Julien LaffayeandGitHub a59fe673c9 Merge pull request #165 from xperimental/fix-travis
Fix Travis build
2019-10-25 13:51:06 -04:00
Julien LaffayeandGitHub 072f1b4f5a Merge pull request #163 from xperimental/go-module
Add Go module definition
2019-10-18 14:46:50 -04:00
Julien Laffaye 7cd8b0bcf3 Fix spelling errors 2019-07-21 21:44:32 +02:00
Julien Laffaye 1c9975e197 gofmt 2019-07-21 21:36:15 +02:00
Julien Laffaye e6de3d35bf Replace DialWithOptions with Dial
No need for a dedicated function as Dial can take no options.
2019-04-23 14:04:25 +02:00
Julien LaffayeandGitHub 9b5a3addd7 Update issue templates 2019-04-17 13:25:58 +02:00
Julien Laffaye 8b7b512afb Add DialWithDebugOutput to log commands. 2019-04-17 13:16:26 +02:00
Julien Laffaye 75b9ebed79 Fix errors in example code 2019-04-15 18:34:29 +02:00
Julien Laffaye 52d3001130 Specify that a server conn is not concurrent safe.
Fixes #128
2019-04-11 17:57:07 +02:00
Julien Laffaye 73b56eeee6 Rework README
Add a badge link to godoc.org
Add a small code example
2019-04-10 20:28:22 +02:00
Julien Laffaye 04b1878733 Add DialWithOptions
DialWithOptions accept a variadic number of options, allowing to
introduce more options in the fure without breaking the API.
2019-04-10 20:25:16 +02:00
Julien Laffaye 55546487cf Use mock for all tests 2019-04-10 20:20:50 +02:00
Julien Laffaye 8019e67744 Add tests for StatusText 2019-01-26 09:10:51 +01:00
Julien Laffaye b218223d02 Use error values in tests 2019-01-22 16:04:06 +01:00
Julien Laffaye 72f5c01749 StatusText returns a text for the FTP status code 2019-01-22 14:54:48 +01:00
Julien Laffaye f75dead520 error strings should not be capitalized (ST1005) 2019-01-22 14:50:39 +01:00
Julien Laffaye 509a294b60 Add missing error check in RemoveDirRecur 2019-01-22 14:47:31 +01:00
Julien LaffayeandGitHub 47f21d10f0 Merge pull request #124 from xperimental/upgrade-go
Update Go version in Travis build.
2018-11-01 12:24:34 +01:00
Julien LaffayeandGitHub fe787349a5 Merge pull request #126 from digineo/go-1.11
Run tests with Go 1.11
2018-10-11 17:09:54 +02:00
Julien Laffaye 2403248fa8 Use last two Go version for travis 2018-04-04 14:35:14 +02:00
Julien LaffayeandGitHub dab2053398 Merge pull request #116 from freman/master
Make it possible to specify what timezone to parse timestamps in
2018-03-22 23:52:25 +01:00
Julien LaffayeandGitHub 427467931c Merge pull request #115 from ncw/fix-pasv
Parse IP address returned with PASV to fix load balanced FTP servers
2018-02-05 00:23:34 +01:00
Julien LaffayeandGitHub 83891dbe00 Merge pull request #110 from digineo/time-parsing
Fix time parsing and reduce syscalls
2018-01-05 08:56:08 +01:00
Julien LaffayeandGitHub 2c34dfa9b1 Merge pull request #111 from digineo/golint
Add golint
2018-01-05 08:53:57 +01:00
Julien LaffayeandGitHub c2fc7f0a5a Merge pull request #101 from digineo/tcpaddr
Use net.TCPAddr to extract remote IP address
2017-12-29 17:48:55 +01:00
Julien LaffayeandGitHub 299b7ff5b6 Merge pull request #106 from laraoz/parseRFC3659ListLine-issue
parseRFC3659ListLine issue
2017-09-27 18:34:33 +02:00
Julien LaffayeandGitHub 769512c448 Merge pull request #98 from digineo/fix_97
Fix possible runtime error
2017-07-21 23:38:41 +02:00
Julien LaffayeandGitHub a05056b3ca Merge pull request #96 from allenluce/zero-link-count
Add a case to catch Unix-like but 0 link count list line
2017-07-07 12:19:14 +02:00
Julien LaffayeandGitHub 6bccbfbf6c Merge pull request #93 from Mojachieee/master
added recursively deleting (non-empty) folders
2017-06-16 09:00:30 +02:00
Julien LaffayeandGitHub 5c7b901224 Merge pull request #87 from DAddYE/patch-1
Avoid forever lock
2017-05-07 20:23:38 +02:00
Julien LaffayeandGitHub 0895dc7f07 Merge pull request #83 from digineo/deadline
Add SetDeadline to Response
2017-04-15 20:58:00 +02:00
Julien LaffayeandGitHub 07efa8ac2b Merge pull request #84 from digineo/go1.8
Test with Go 1.7.5 and 1.8.1
2017-04-15 20:55:39 +02:00
Julien Laffaye 7b85eb4638 Document ServerConn is not safe for concurrent use.
Mention textproto.Error so users can access the error code via type
assertion (issue #78).
2017-03-04 13:34:31 +01:00
Julien LaffayeandGitHub cb3924c5c9 Merge pull request #80 from mappu/master
ftp: fix OPTS UTF8 ON for Filezilla Server
2017-03-04 13:04:48 +01:00
Julien Laffaye 602886c6b8 Do not export the scanner type
It is an internal specific to parse list responses.
2017-03-04 13:01:41 +01:00
Julien Laffaye 68918a8852 Remove useless assignment 2017-03-04 12:58:20 +01:00
Julien LaffayeandGitHub 106ab1b13b Merge pull request #76 from vahid-sohrabloo/patch-1
Add Size Command
2017-02-21 10:41:17 +01:00
Julien Laffaye de604c9776 Expose disableEPSV
Fixes #71
2017-02-05 21:02:16 +01:00
Julien LaffayeandGitHub 4596ddad4d Merge pull request #73 from digineo/move-utf8
Switch to UTF-8 after login
2017-02-05 20:45:42 +01:00
Julien LaffayeandGitHub a5c2cfe9ac Merge pull request #64 from digineo/mlst
Use MLST if supported
2017-01-30 14:43:20 +01:00
Julien LaffayeandGitHub 5a8b8eeb12 Merge pull request #66 from zeast/master
use utf8 default
2017-01-20 09:08:54 +01:00
Julien LaffayeandGitHub 0757556863 Merge pull request #63 from digineo/refactor_line_parsing
Refactoring the line parsing
2017-01-19 16:22:41 +01:00
Julien LaffayeandGitHub 95f4fe9d35 Merge pull request #62 from svett/fix-filename-parsing
Fix incorrect filename parsing
2016-12-29 18:20:21 +01:00
Julien Laffaye 988909ab28 Disable EPSV for tests.
Also disable it for next attempts when it failed.
2016-11-24 14:49:16 +01:00
Julien Laffaye 72154dff87 Use last Go version 2016-11-24 12:25:00 +01:00