Commit Graph
100 Commits
Author SHA1 Message Date
Julien Laffaye 0de5c29d45 Fix issues reported by staticcheck 2020-10-21 22:10:46 +02:00
Julien LaffayeandGitHub 333201f85f Merge pull request #213 from mafredri/fix-tests
Fix tests
2020-10-21 15:28:09 -04:00
Julien LaffayeandGitHub 9aec86d811 Merge pull request #212 from mafredri/remove-naked-returns
Remove naked returns
2020-10-21 15:27:15 -04:00
Julien LaffayeandGitHub a50ad6ffd6 Merge pull request #202 from ncw/fix-197-FEAT
Implement PRET command for distributed ftp servers, eg drftpd
2020-10-19 13:47:21 -04:00
Julien LaffayeandGitHub 43afc84ae3 Merge pull request #199 from ncw/fix-198
Fix Stor() no longer reporting errors from the io.Reader passed in
2020-10-19 10:04:29 -04:00
Julien LaffayeandGitHub 1344bef09e Merge pull request #201 from ncw/fix-200-FEAT
Delay FEAT command until after Login - fixes #200
2020-10-19 10:01:38 -04:00
Julien LaffayeandGitHub 39e3779af0 Merge pull request #192 from drakkan/resp_error
try to read the server response after a failed upload
2020-08-12 10:35:50 -04:00
Julien LaffayeandGitHub c2ee4fa250 Merge pull request #178 from crazy-max/optional-utf8
Make "OPTS UTF8 ON" optional
2020-07-30 09:57:23 -04:00
Julien LaffayeandGitHub a3536fc55e Merge pull request #183 from jawr/walker_path_fix
Rework walker.Next
2020-07-28 14:05:16 -04:00
Julien LaffayeandGitHub e31b4effea Merge pull request #188 from Techassi/typeentry-string
EntryType String() function
2020-07-28 13:54:05 -04:00
Julien LaffayeandGitHub 13949d3891 Merge pull request #190 from ncw/fix-pureftpd
Workaround pure-ftpd connections failing with "Unknown command"
2020-07-20 15:47:10 -04:00
Julien LaffayeandGitHub 5d10dd64f6 Merge pull request #187 from novalagung/master
add documentation shortcut
2020-07-15 12:42:56 -04:00
Julien LaffayeandGitHub 55bbb372b8 Merge pull request #185 from digineo/code-improvements
Code improvements
2020-07-08 13:50:26 -04:00
Julien LaffayeandGitHub 5563613968 Merge pull request #176 from vcraescu/fix_walk
fix_walk
2020-06-02 14:09:15 -04:00
Julien Laffaye b9f3ade291 Merge branch 'master' of github.com:jlaffaye/ftp 2020-04-23 00:49:57 +02:00
Julien Laffaye ac1574d383 Add DialWithExplicitTLS 2020-04-23 00:49:43 +02:00
Julien LaffayeandGitHub 59f85871cf Merge pull request #169 from flowrean/append-cmd
Add support for FTP append (APPE) command
2020-04-22 18:29:36 -04:00
Julien Laffaye d4caf6ffca Add close on read example
Fixes #171
2020-03-31 16:49:19 +02:00
Julien LaffayeandGitHub 041eae9a3d Merge pull request #141 from johnepiscopo/add-walk
Adds the ability to walk through a directory tree
2020-03-13 11:03:37 -04:00
Julien Laffaye 6841a2daa0 stale bot: ignore accepted issues 2020-03-09 18:13:36 +01:00
Julien Laffaye e1b8fdd0dc Add stale bot 2019-12-17 23:19:57 -05:00
Julien LaffayeandGitHub a59fe673c9 Merge pull request #165 from xperimental/fix-travis
Fix Travis build
2019-10-25 13:51:06 -04:00
Julien LaffayeandGitHub 072f1b4f5a Merge pull request #163 from xperimental/go-module
Add Go module definition
2019-10-18 14:46:50 -04:00
Julien Laffaye 7cd8b0bcf3 Fix spelling errors 2019-07-21 21:44:32 +02:00
Julien Laffaye 1c9975e197 gofmt 2019-07-21 21:36:15 +02:00
Julien Laffaye e6de3d35bf Replace DialWithOptions with Dial
No need for a dedicated function as Dial can take no options.
2019-04-23 14:04:25 +02:00
Julien LaffayeandGitHub 9b5a3addd7 Update issue templates 2019-04-17 13:25:58 +02:00
Julien Laffaye 8b7b512afb Add DialWithDebugOutput to log commands. 2019-04-17 13:16:26 +02:00
Julien Laffaye 75b9ebed79 Fix errors in example code 2019-04-15 18:34:29 +02:00
Julien Laffaye 52d3001130 Specify that a server conn is not concurrent safe.
Fixes #128
2019-04-11 17:57:07 +02:00
Julien Laffaye 73b56eeee6 Rework README
Add a badge link to godoc.org
Add a small code example
2019-04-10 20:28:22 +02:00
Julien Laffaye 04b1878733 Add DialWithOptions
DialWithOptions accept a variadic number of options, allowing to
introduce more options in the fure without breaking the API.
2019-04-10 20:25:16 +02:00
Julien Laffaye 55546487cf Use mock for all tests 2019-04-10 20:20:50 +02:00
Julien Laffaye 8019e67744 Add tests for StatusText 2019-01-26 09:10:51 +01:00
Julien Laffaye b218223d02 Use error values in tests 2019-01-22 16:04:06 +01:00
Julien Laffaye 72f5c01749 StatusText returns a text for the FTP status code 2019-01-22 14:54:48 +01:00
Julien Laffaye f75dead520 error strings should not be capitalized (ST1005) 2019-01-22 14:50:39 +01:00
Julien Laffaye 509a294b60 Add missing error check in RemoveDirRecur 2019-01-22 14:47:31 +01:00
Julien LaffayeandGitHub 47f21d10f0 Merge pull request #124 from xperimental/upgrade-go
Update Go version in Travis build.
2018-11-01 12:24:34 +01:00
Julien LaffayeandGitHub fe787349a5 Merge pull request #126 from digineo/go-1.11
Run tests with Go 1.11
2018-10-11 17:09:54 +02:00
Julien Laffaye 2403248fa8 Use last two Go version for travis 2018-04-04 14:35:14 +02:00
Julien LaffayeandGitHub dab2053398 Merge pull request #116 from freman/master
Make it possible to specify what timezone to parse timestamps in
2018-03-22 23:52:25 +01:00
Julien LaffayeandGitHub 427467931c Merge pull request #115 from ncw/fix-pasv
Parse IP address returned with PASV to fix load balanced FTP servers
2018-02-05 00:23:34 +01:00
Julien LaffayeandGitHub 83891dbe00 Merge pull request #110 from digineo/time-parsing
Fix time parsing and reduce syscalls
2018-01-05 08:56:08 +01:00
Julien LaffayeandGitHub 2c34dfa9b1 Merge pull request #111 from digineo/golint
Add golint
2018-01-05 08:53:57 +01:00
Julien LaffayeandGitHub c2fc7f0a5a Merge pull request #101 from digineo/tcpaddr
Use net.TCPAddr to extract remote IP address
2017-12-29 17:48:55 +01:00
Julien LaffayeandGitHub 299b7ff5b6 Merge pull request #106 from laraoz/parseRFC3659ListLine-issue
parseRFC3659ListLine issue
2017-09-27 18:34:33 +02:00
Julien LaffayeandGitHub 769512c448 Merge pull request #98 from digineo/fix_97
Fix possible runtime error
2017-07-21 23:38:41 +02:00
Julien LaffayeandGitHub a05056b3ca Merge pull request #96 from allenluce/zero-link-count
Add a case to catch Unix-like but 0 link count list line
2017-07-07 12:19:14 +02:00
Julien LaffayeandGitHub 6bccbfbf6c Merge pull request #93 from Mojachieee/master
added recursively deleting (non-empty) folders
2017-06-16 09:00:30 +02:00
Julien LaffayeandGitHub 5c7b901224 Merge pull request #87 from DAddYE/patch-1
Avoid forever lock
2017-05-07 20:23:38 +02:00
Julien LaffayeandGitHub 0895dc7f07 Merge pull request #83 from digineo/deadline
Add SetDeadline to Response
2017-04-15 20:58:00 +02:00
Julien LaffayeandGitHub 07efa8ac2b Merge pull request #84 from digineo/go1.8
Test with Go 1.7.5 and 1.8.1
2017-04-15 20:55:39 +02:00
Julien Laffaye 7b85eb4638 Document ServerConn is not safe for concurrent use.
Mention textproto.Error so users can access the error code via type
assertion (issue #78).
2017-03-04 13:34:31 +01:00
Julien LaffayeandGitHub cb3924c5c9 Merge pull request #80 from mappu/master
ftp: fix OPTS UTF8 ON for Filezilla Server
2017-03-04 13:04:48 +01:00
Julien Laffaye 602886c6b8 Do not export the scanner type
It is an internal specific to parse list responses.
2017-03-04 13:01:41 +01:00
Julien Laffaye 68918a8852 Remove useless assignment 2017-03-04 12:58:20 +01:00
Julien LaffayeandGitHub 106ab1b13b Merge pull request #76 from vahid-sohrabloo/patch-1
Add Size Command
2017-02-21 10:41:17 +01:00
Julien Laffaye de604c9776 Expose disableEPSV
Fixes #71
2017-02-05 21:02:16 +01:00
Julien LaffayeandGitHub 4596ddad4d Merge pull request #73 from digineo/move-utf8
Switch to UTF-8 after login
2017-02-05 20:45:42 +01:00
Julien LaffayeandGitHub a5c2cfe9ac Merge pull request #64 from digineo/mlst
Use MLST if supported
2017-01-30 14:43:20 +01:00
Julien LaffayeandGitHub 5a8b8eeb12 Merge pull request #66 from zeast/master
use utf8 default
2017-01-20 09:08:54 +01:00
Julien LaffayeandGitHub 0757556863 Merge pull request #63 from digineo/refactor_line_parsing
Refactoring the line parsing
2017-01-19 16:22:41 +01:00
Julien LaffayeandGitHub 95f4fe9d35 Merge pull request #62 from svett/fix-filename-parsing
Fix incorrect filename parsing
2016-12-29 18:20:21 +01:00
Julien Laffaye 988909ab28 Disable EPSV for tests.
Also disable it for next attempts when it failed.
2016-11-24 14:49:16 +01:00
Julien Laffaye 72154dff87 Use last Go version 2016-11-24 12:25:00 +01:00
Julien LaffayeandGitHub 17dda2a76c Merge pull request #59 from digineo/close-fix
Add missing Close() before return
2016-11-24 10:15:47 +01:00
Julien LaffayeandGitHub c47cb8ca13 Merge pull request #54 from 0086/master
Fix ls bug for file or folder name includes multiple spaces
2016-11-24 10:13:12 +01:00
Julien Laffaye 025815df64 Merge pull request #51 from brianfoshee/update-go-version
Add Go 1.6 test target as well as most recent 1.5 release
2016-02-29 22:52:38 +01:00
Julien Laffaye 0e072be722 Merge pull request #43 from HnH/master
ServerConn::openDataConn() recursively tries to use EPSV and PASV.
2016-02-27 11:10:24 +01:00
Julien Laffaye 3e92923fa0 Merge pull request #48 from ezeql/patch-1
Update README.md
2016-02-10 22:23:03 +01:00
Julien Laffaye fc06ecffd6 Merge pull request #47 from etix/hotfix
Fix a crash with pasv invalid responses
2016-02-08 20:19:59 +01:00
Julien Laffaye 8b4b15b841 Merge pull request #44 from digineo/fix_time_parsing
Do not crash on invalid lines
2015-12-28 18:04:02 +01:00
Julien Laffaye f780314026 Use latest Go version.
Remove cover tool, it is now part of Go.
2015-12-01 23:05:03 +01:00
Julien Laffaye ff69fe44f1 Make gofmt and golint happy. 2015-11-30 12:22:16 +01:00
Julien Laffaye a104f27d44 Merge pull request #41 from digineo/avoid_strings_split
Avoid strings.Split
2015-09-01 23:31:23 +02:00
Julien Laffaye 5260d41db2 Merge pull request #42 from digineo/multiline_mock
Create mock for multiline test
2015-09-01 23:28:59 +02:00
Julien Laffaye 1b24570309 Add ReportCard badge. 2015-08-28 15:52:55 +02:00
Julien Laffaye db9aa14e61 Merge pull request #40 from andybalholm/master
Add support for directory listings in MS-DOS DIR format.
2015-08-25 09:22:57 +02:00
Julien Laffaye 7acded32b2 Add a test for the legacy Connect function. 2015-08-21 18:47:44 +02:00
Julien Laffaye d640995c66 Add tests for timeout and wrong login. 2015-08-21 18:36:56 +02:00
Julien Laffaye 7534ffcb97 Add a test for RetrFrom method. 2015-08-20 22:47:09 +02:00
Julien Laffaye 4cb43e6615 Merge pull request #39 from digineo/increase_test_coverage
Increase test coverage
2015-08-20 11:06:57 +02:00
Julien Laffaye fb305c5912 Merge pull request #38 from digineo/test_pasv
Test PASV as well
2015-08-20 09:37:12 +02:00
Julien Laffaye 201b5505ae Merge pull request #37 from digineo/coveralls
Add coveralls.io to display test coverage
2015-08-19 21:18:42 +02:00
Julien Laffaye 519b366223 Silence StatusNotImplemented error for Logout() 2015-08-19 00:17:44 +02:00
Julien Laffaye c741076986 Merge pull request #35 from digineo/code_optimizations
Some code optimizations
2015-08-18 23:43:34 +02:00
Julien Laffaye b33f6e0005 Fix EPSV for domains with multiple A entries.
We can not use the DNS name to open the data connection, as we might get
another IP than the current host from the DNS resolution.
2015-08-18 23:38:53 +02:00
Julien Laffaye 23b395751d Merge pull request #33 from digineo/ipv6
Use localhost to test IPv6 connectivity
2015-08-18 23:07:04 +02:00
Julien Laffaye 994e6a4239 Merge pull request #34 from digineo/improve_parsing
Improve line parsing
2015-08-18 22:50:39 +02:00
Julien Laffaye c69930155d Merge pull request #32 from digineo/travis
Add Travis CI
2015-08-18 21:22:31 +02:00
Julien Laffaye e6587b1638 Merge pull request #31 from digineo/listings
Add support for more listing formats
2015-08-18 19:17:10 +02:00
Julien Laffaye 0ae5d598fa Use prefered API function. 2015-08-18 19:03:26 +02:00
Julien Laffaye 3e21d70d53 Skip TestConnIPv6 in short mode. 2015-08-18 19:02:23 +02:00
Julien Laffaye e987451f99 SplitHostPort before connecting to the remote.
This, way, we dont have to cleanup the tcp connection if SplitHostPort fails.
2015-08-18 19:00:56 +02:00
Julien Laffaye aae10f216b Merge branch 'stacktic-ipv6' 2015-08-18 18:59:16 +02:00
Julien Laffaye a6e47bb27d Merge branch 'ipv6' of https://github.com/stacktic/ftp into stacktic-ipv6
Conflicts:
	ftp.go
2015-08-18 18:52:29 +02:00
Julien Laffaye 110a39bff4 Skip functional testing in short mode. 2015-08-18 18:39:31 +02:00
Julien Laffaye a5b2614a99 Merge pull request #8 from dsluis/master
Changing expected status response for Logout call
2015-08-18 18:13:03 +02:00
Julien Laffaye 061d4ea288 Merge pull request #13 from stacktic/rest
Add support for the REST command
2015-08-18 18:05:20 +02:00