brouzouf/ftp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
268 Commits 8 Branches 6 Tags
Commit Graph

268 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ivan Andreev
53b6bfa4cd Nudge control connection deadline before reading the data closing status 2021-09-11 16:36:35 +03:00
Julien Laffaye
5d41901190 Fix issues reported by goimports 2021-03-06 19:44:19 -05:00
Julien Laffaye
64cacdb711 Fix issues reported by shadow 2021-03-06 19:43:28 -05:00
Julien Laffaye
05cd33e2ad Fix issues reported by errcheck 2021-03-06 19:36:26 -05:00
Julien Laffaye
52feea7744 Fix spelling error reported by goreportcard.com 2021-03-05 10:58:28 -05:00
Julien Laffaye
23a84a6d0e Replace godoc badge with pkg.go.dev 2021-03-05 10:52:22 -05:00
Julien Laffaye
c3c8c7ac65
Merge pull request #219 from ivandeex/master 
trim trailing whitespace from the list commands
 2021-03-02 14:57:56 -05:00
Julien Laffaye
cc3a8b417c
Merge pull request #221 from ncw/fix-tls-zero-length 
Fix STOR of zero length files to ProFTPd with TLS
 2021-03-02 14:53:12 -05:00
Nick Craig-Wood
a4e9650823 Fix STOR of zero length files to ProFTPd with TLS 
Before this change, uploading a zero length file via TLS meant that
the tls.Handshake function was never called.

ProFTPd quite properly refuses to accept an empty TCP connection with
no TLS handshake as a zero length upload and gives the error

    425 Unable to build data connection: Operation not

See: https://forum.rclone.org/t/rclone-ftps-explicit-rclone-touch-empty-files-proftpd-unable-to-build-data-connection-operation-not-permitted/22522
 2021-03-01 16:01:20 +00:00
Ivan Andreev
24897db640 Trim trailing whitespace from list commands 
Listing a current directory (when the path argument is empty)
would send the command "LIST " with trailing whitespace to FTP
resulting in 500 errors with Solaris FTP server.
This patch fixes that.
 2021-02-14 19:48:19 +03:00
Julien Laffaye
9aae4d1511
Merge pull request #196 from ncw/fix-disable-mlsd 
Add a DialWithDisabledMLSD option to ignore MLSD if advertised
 2020-11-12 14:50:30 -05:00
Nick Craig-Wood
624bcac8b4 Add a DialWithDisabledMLSD option to ignore MLSD if advertised 
This is useful for servers which advertise MLSD (eg some versions of
Serv-U) but don't support it properly.
 2020-11-05 11:42:34 +00:00
Julien Laffaye
0de5c29d45 Fix issues reported by staticcheck 2020-10-21 22:10:46 +02:00
Julien Laffaye
333201f85f
Merge pull request #213 from mafredri/fix-tests 
Fix tests
 2020-10-21 15:28:09 -04:00
Julien Laffaye
9aec86d811
Merge pull request #212 from mafredri/remove-naked-returns 
Remove naked returns
 2020-10-21 15:27:15 -04:00
Mathias Fredriksson
420cf7bbfd
Fix tests 2020-10-20 21:16:41 +03:00
Mathias Fredriksson
744ff9c18a
Remove naked returns 2020-10-20 20:51:56 +03:00
Julien Laffaye
a50ad6ffd6
Merge pull request #202 from ncw/fix-197-FEAT 
Implement PRET command for distributed ftp servers, eg drftpd
 2020-10-19 13:47:21 -04:00
Nick Craig-Wood
fcad893ae7 Implement PRET command for distributed ftp servers, eg drftpd 
See: https://tools.ietf.org/html/draft-dd-pret-00

Fixes #197
 2020-10-19 17:59:40 +01:00
Julien Laffaye
43afc84ae3
Merge pull request #199 from ncw/fix-198 
Fix Stor() no longer reporting errors from the io.Reader passed in
 2020-10-19 10:04:29 -04:00
Julien Laffaye
1344bef09e
Merge pull request #201 from ncw/fix-200-FEAT 
Delay FEAT command until after Login - fixes #200
 2020-10-19 10:01:38 -04:00
Nick Craig-Wood
9f5200151c Delay FEAT command until after Login - fixes #200 
Some servers require the user to be logged in to run FEAT

    ftp://serverftp:2121: Connecting to FTP server
    FTP Rx: "220 DrFTPD+ 2.0 (+STABLE+) $Revision: 1949 $ http://drftpd.org"
    FTP Tx: "AUTH TLS"
    FTP Rx: "234 AUTH TLS successful"
    FTP Tx: "FEAT"
    FTP Rx: "530 Not logged in."
 2020-09-12 11:30:42 +01:00
Nick Craig-Wood
c0343a706b Fix Stor() no longer reporting errors from the io.Reader passed in 
This commit

4a68979b896a741e always return the ReadResponse error after an upload

Broke the error return from Stor().  If you attempt to upload a file
with Stor() and the io.Reader that you passed in returns an error,
this was not returned by the Stor() command leading the user to think
the file was uploaded correctly.

This was detected by rclone's unit tests and the exact commit was
pinpointed with git commit.

This commit fixes it by returning the error from io.Copy or the error
from ReadResponse - the latter if they are both set.

Fixes #198
 2020-09-11 17:14:05 +01:00
Julien Laffaye
39e3779af0
Merge pull request #192 from drakkan/resp_error 
try to read the server response after a failed upload
 2020-08-12 10:35:50 -04:00
Nicola Murino
4a68979b89 always return the ReadResponse error after an upload 2020-08-06 16:44:05 +02:00
Julien Laffaye
c2ee4fa250
Merge pull request #178 from crazy-max/optional-utf8 
Make "OPTS UTF8 ON" optional
 2020-07-30 09:57:23 -04:00
Nicola Murino
08a1e2e380 try to read the server response after a failed upload 
if the upload failed we still need to try to read the server
response otherwise if the failure is not due to a connection problem,
for example the server denied the upload for quota limits, we miss
the response and we cannot use the connection to send other commands

Here is what happen before this patch:

C->S STOR test_file1.dat
S->C 150 Using transfer connection
S->C 550 Could not transfer file: denying write due to space limit

the client does not read the above 550 response and send the next command, so
the response for the STOR response will be readed as response for the next
command
 2020-07-30 14:55:31 +02:00
CrazyMax
696d865fa3
Opt-out 2020-07-28 21:13:33 +02:00
Julien Laffaye
a3536fc55e
Merge pull request #183 from jawr/walker_path_fix 
Rework walker.Next
 2020-07-28 14:05:16 -04:00
Julien Laffaye
e31b4effea
Merge pull request #188 from Techassi/typeentry-string 
EntryType String() function
 2020-07-28 13:54:05 -04:00
Julien Laffaye
13949d3891
Merge pull request #190 from ncw/fix-pureftpd 
Workaround pure-ftpd connections failing with "Unknown command"
 2020-07-20 15:47:10 -04:00
Nick Craig-Wood
6563ce9dff Workaround pure-ftpd connections failing with "Unknown command" 
pure-ftpd 1.0.49-4 as supplied as part of Ubuntu 20.04 advertises UTF8
support in the FEAT command but the OPTS command fails to turn it on.

    OPTS UTF8 ON
    504 Unknown command

This patch introduces a workaround to ignore the error which enables
this library to work with this version of pure-ftpd. Filezilla appears
to ignore this error in a similar way.
 2020-07-18 14:21:12 +01:00
Techassi
3e3979ddc6
Add String() function 2020-07-17 18:01:41 +02:00
Julien Laffaye
5d10dd64f6
Merge pull request #187 from novalagung/master 
add documentation shortcut
 2020-07-15 12:42:56 -04:00
Noval Agung Prayogo
ee0d349f0d
add documentation shortcut, to make user able to go there easlity without typing it 2020-07-15 12:50:26 +07:00
Julien Laffaye
55bbb372b8
Merge pull request #185 from digineo/code-improvements 
Code improvements
 2020-07-08 13:50:26 -04:00
Julian Kornberger
7ec48e555e Use subtests and assert() 2020-07-08 08:33:57 +02:00
Julian Kornberger
c6fe263756 Add status string for unknown status codes 2020-07-08 08:23:44 +02:00
Julian Kornberger
0d36957938 Update dependencies 2020-07-08 08:20:38 +02:00
jawr
226f00fd00 try and improve coveralls 2020-06-15 09:53:47 +09:00
jawr
06706f2625 Rework walker.Next to (hopefully) be clearer. Fix issues where it wouldn't correctly walk a directory with one file. Also prevent it trimming leading '/' from root. 2020-06-15 09:33:28 +09:00
Julien Laffaye
5563613968
Merge pull request #176 from vcraescu/fix_walk 
fix_walk
 2020-06-02 14:09:15 -04:00
CrazyMax
01c291065f
Move func 2020-05-05 21:04:03 +02:00
CrazyMax
83f3ade61d
Fix ftpMock 2020-05-05 13:34:35 +02:00
CrazyMax
0a6572881e
Udpate ftpMock 2020-05-05 13:22:37 +02:00
CrazyMax
c21b2b322e
Update tests 2020-05-05 13:08:53 +02:00
CrazyMax
60012218fd
Make "OPTS UTF8 ON" optional (#172) 2020-05-05 13:04:49 +02:00
Viorel Craescu
3b6697e5b6 fix_walk 2020-04-26 10:28:15 +03:00
Julien Laffaye
b9f3ade291 Merge branch 'master' of github.com:jlaffaye/ftp 2020-04-23 00:49:57 +02:00
Julien Laffaye
ac1574d383 Add DialWithExplicitTLS 2020-04-23 00:49:43 +02:00